custom-war-packager icon indicating copy to clipboard operation
custom-war-packager copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Make plugin Group IDs optional in the YAML specification #171

Open natsen opened this issue 2 years ago • 5 comments

  • Added UpdateCenterPluginInfoProvider.getGroupId(String artifactId) to use the groupIdCache and fetch the groupId

  • In DependencyInfo using PluginInfoProvider.getGroupId(artifactId) to fetch groupId. groupId field is now optional when Update Center Plugin plugin info Provider s used, which is the default.

  • Updated sample.yml to include a plugin without groupId for test coverage. Link to Github issue: https://github.com/jenkinsci/custom-war-packager/issues/171

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!

  • [x] Ensure that the pull request title represents the desired changelog entry

  • [x] Please describe what you did

  • [x] Link to relevant issues in GitHub or Jira

  • [x] Link to relevant pull requests, esp. upstream and downstream changes

  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

natsen avatar Nov 15 '22 04:11 natsen

The build and tests are passing locally. The failing checks are unrelated to the change in this PR. I observe the previous PR's were also failing similarly. I could not figure out why. Can someone help fix the existing master so this PR can pass the checks.

[INFO] Reactor Summary for Jenkins Custom WAR Packager Parent POM 2.0-alpha-7-SNAPSHOT: [INFO] [INFO] Jenkins Custom WAR Packager Parent POM ............. SUCCESS [ 1.363 s] [INFO] Jenkins Custom WAR Packager Library ................ SUCCESS [ 5.948 s] [INFO] Jenkins Custom WAR Packager CLI .................... SUCCESS [ 20.060 s] [INFO] Jenkins Custom WAR Packager Maven Plugin ........... SUCCESS [01:43 min] [INFO] Integration tests for Custom war Packager and Jenkinsfile Runner SUCCESS [16:03 min] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:14 min [INFO] Finished at: 2022-11-15T18:17:26-08:00 [INFO] ------------------------------------------------------------------------

natsen avatar Nov 16 '22 02:11 natsen

@oleg-nenashev this is my first PR. can you suggest if there is anything I can help with to get this PR through.

natsen avatar Nov 22 '22 19:11 natsen

@oleg-nenashev can you let me help fix this issue with the CI that is blocking my PR

natsen avatar Feb 07 '23 21:02 natsen

I am cleaning up the code in another branch. But yes, let's try to get it landed

oleg-nenashev avatar Feb 08 '23 08:02 oleg-nenashev

any updates. anything I can do to get this merged.

natsen avatar Apr 06 '23 00:04 natsen