custom-tools-plugin icon indicating copy to clipboard operation
custom-tools-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

[WIP][JENKINS-30680] Pipeline compatibility

Open alexbrjo opened this issue 7 years ago • 2 comments

Pipeline compatibility. see JENKINS-30680

  • [X] Compatibility with pipeline
  • [X] Snippet generator
  • [X] Used tools action added to job
    • [ ] aesthetic jelly for the action page
  • [ ] backwards / binary compatibility

Implementation Since BuildWrapper#decorateLauncher() is only honored for AbstractProject's, I tried to keep parity between FreeStyle and Workflow jobs by moving the logic for adding environment variables to BuildWrapper#setup()

alexbrjo avatar Jul 24 '17 13:07 alexbrjo

@alexbrjo Hi Alex. FYI I have reopened this pull-request. I am working on removing Extended Choice dependency as a part of JENKINS-32662 / JENKINS-46141/other such issues.

It apepars it is not possible to do the refactoring in a compatible way due to the architecture issues I have introduced in 2013. But it's too hot due to the security issue in Extended Choice, so I lean towards breaking the compatibility and releasing 1.0.

It makes the current pull request compliant, so I will probably refactor and land this pull request in 1.0

oleg-nenashev avatar Sep 18 '17 12:09 oleg-nenashev

FTR the parallel work is here: https://github.com/jenkinsci/customtools-plugin/pull/29

oleg-nenashev avatar Sep 18 '17 14:09 oleg-nenashev