Initial credentials implementation of experimental views
Fixes https://github.com/jenkinsci/credentials-plugin/pull/626 Part of https://github.com/jenkinsci/sig-ux/issues/10
Known issues:
- ~help link to system / job credentials page not implemented~
- jenkins-page-description takes up space even if its empty
- Credentials side panel link isn't selected for sub pages
- Credentials get cut off on system page
Screenshot
- sub pages don't have the page wrapper so look out of place
Details
- Page header on job page is job name not credentials and tabs are missing
Screenshot
- Page overflows on user credentials (confirmed as pre-existing issue), seeing similar on JCasC think we need a core fix
Screenshot
cc @janfaracik
Testing done
Submitter checklist
- [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests that demonstrate the feature works or the issue is fixed
I think that's all the system settings pages sorted.
Job I'll see what I can do but I think its missing functionality.
I'll need to do a pass over all the user pages as well and make sure they are all fine / if there's any cleanup that can be done for them (there should be)
@janfaracik there's something quite off with tables in core they can break out of the container and scroll the page =/
Adding sidepanel and using a table layout doesn't work very well.
Thoughts?
This is my credential that really breaks the layout on a 13" screen:
C=XX,ST=StateName,L=CityName,O=CompanyName,OU=CompanySectionName,CN=CommonNameOrHostname
To fix this case I'm thinking of doing something like:
Previously:
That would be looping over each store and not repeating all that information in the table. Ideally including domain in there as well in a more subtle way
@janfaracik you able to check this over?
I think its all working now.
I removed the job subpage as it didn't really seem to work for this at all and it needs more work.
I'll look at doing a PR to rework the table soon as well I don't think its 100% essential to be in before this
@janfaracik you able to check this over?
I think its all working now.
Looking good - no obvious issues. I think it'll work a lot better once the cards are in.
Wouldn't repeat the app bar buttons on various configure pages, e.g. I'd remove Update/Delete from the Move page, but if we do go down a dialog route this is fine for now.
I think this is ready after the next weekly release.
I think it'll work a lot better once the cards are in.
PR here to show what it'll look like: https://github.com/jenkinsci/credentials-plugin/pull/985