credentials-plugin icon indicating copy to clipboard operation
credentials-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Remove useless broken "Add" button on credentials-select-control.

Open jamie-pate opened this issue 2 years ago • 3 comments

I don't know if there is a way to get a 'data-url' into the template to actually fix this button.

See this change that broke it: https://github.com/jenkinsci/credentials-plugin/commit/9c5bb72106824ea826ba0d5e4d63fe5d2a11aa91#diff-45693b8474f3341b5d603b463cd4c10f4ec301a1c8c1c89b67034ba81056dfc9R44

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x ] Ensure that the pull request title represents the desired changelog entry
  • [x ] Please describe what you did
  • [? ] Link to relevant issues in GitHub or Jira (there is no issues tab on github, and where is this Jira?)
  • [x ] Link to relevant pull requests, esp. upstream and downstream changes
  • [? ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

jamie-pate avatar Sep 16 '22 20:09 jamie-pate

can you describe in detail what doesn;t work or why it is broken? Perhaps a Jira issue?

jtnord avatar Dec 14 '22 09:12 jtnord

It looks like it was just left out in a refactor but never removed... It just does nothing

jamie-pate avatar Dec 15 '22 05:12 jamie-pate

https://github.com/jenkinsci/credentials-plugin/blob/3f165e9abbdf4c608f86eea2ceb9e0d53c068ef0/src/main/resources/lib/credentials/select.jelly#L151-L154 ?

jtnord avatar Oct 02 '23 16:10 jtnord