credentials-plugin icon indicating copy to clipboard operation
credentials-plugin copied to clipboard

[JENKINS-59109] Bind triggering user's credentials

Open sbgertp opened this issue 3 years ago • 3 comments

Fixes JENKINS-59109

sbgertp avatar May 19 '21 13:05 sbgertp

Yeah I think this might be backwards. I'd expect a build with a build step to bind its credential parameter bindings to the invoked build.

jvz avatar May 19 '21 19:05 jvz

Yeah I think this might be backwards. I'd expect a build with a build step to bind its credential parameter bindings to the invoked build.

I agree that the binding should happen at the call site of the upstream build creating the downstream one. But changing the architecture for me is a bit much, so I framed this as a bug of the current implementation - it already performs deferred binding of credentials if directly started by the user, it was just missing the case when started by the user as part of a causal chain.

sbgertp avatar May 20 '21 08:05 sbgertp

Oh that's interesting! Let me verify this works equivalently to what I had in mind before I can merge this. Should be within the next few days.

jvz avatar May 20 '21 14:05 jvz