copyartifact-plugin
copyartifact-plugin copied to clipboard
jenkinsci
[JENKINS-12134] Only fingerprint if source does.
This only fingerprints if the source project has "fingerprint all archived artifacts" enabled. This also adds tests for this behavior.
Creating a pull request to get some more eyes on this before I push it to master.
I've released 1.21 with better implementation of this that hopefully hides the overhead. Keeping this pull request open in case he still complains, but we shouldn't merge this until that's confirmed.
Sounds good
On Thu, Jan 12, 2012 at 2:14 PM, Kohsuke Kawaguchi < [email protected]
wrote:
I've released 1.21 with better implementation of this that hopefully hides the overhead. Keeping this pull request open in case he still complains, but we shouldn't merge this until that's confirmed.
Reply to this email directly or view it on GitHub:
https://github.com/jenkinsci/copyartifact-plugin/pull/8#issuecomment-3471539
I would still like to make it optional, as with a large number of small artifacts, the fingerprinting process takes much longer than the actual IO, even after 1.21
+1 to skipping fingerprint if neither source nor destination project use fingerprinting at all.
+1 to make fingerprinting optional. Fingerprinting is overhead for our build process.
Sounds good to me. If the optionality is per artifacted file, this is exactly like I'd expect copy artifacts to work. Ie you can copy many files in one copy artifacts request, some of them are fingerprinted, some are not.
Btw, https://github.com/jenkinsci/copyartifact-plugin/pull/11 also implements this functionality. Could you please work with the author of the other pull request decide which of these makes more sense and have that one reviewed and the other one closed?
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests
