configuration-as-code-plugin icon indicating copy to clipboard operation
configuration-as-code-plugin copied to clipboard

Adding Demo for View-Job-Filters plugin

Open dheerajodha opened this issue 4 years ago • 5 comments

This PR adds demo for the "View Job Filters" plugin.

  • Added yaml file containing the configuration.
  • Added README.md file
  • Added Test file, to test the configuration.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • [x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [ ] Link to relevant issues in GitHub or in Jenkins JIRA
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Did you provide a test-case? That demonstrates feature works or fixes the issue.

dheerajodha avatar May 10 '21 14:05 dheerajodha

I'm getting compilation errors, the classes "BuildDurationFilter", "BuildStatusFilter" and "SecurityFilter" are not found. I tried it locally as well on Eclipse, I referred to the javadocs of hudson.views to get the path of these above-mentioned classes, so that I can import them.

For example, to get the path of class "BuildDurationFilter" I went here and copied the mentioned path on top: "hudson.views.BuildDurationFilter"

What is the correct way of importing the classes?

dheerajodha avatar May 11 '21 09:05 dheerajodha

I'm getting compilation errors, the classes "BuildDurationFilter", "BuildStatusFilter" and "SecurityFilter" are not found. I tried it locally as well on Eclipse, I referred to the javadocs of hudson.views to get the path of these above-mentioned classes, so that I can import them.

For example, to get the path of class "BuildDurationFilter" I went here and copied the mentioned path on top: "hudson.views.BuildDurationFilter"

What is the correct way of importing the classes?

Add a dependency on the plugin in the integrations folder: https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/integrations/pom.xml

timja avatar May 11 '21 09:05 timja

Are you still interested in this?

timja avatar Aug 07 '21 15:08 timja

Oh yes, forgot about this so I will try working on this and if I'm not able to do this within few days I'll let you know here.

dheerajodha avatar Aug 08 '21 02:08 dheerajodha

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 06:04 stale[bot]

Codecov Report

Merging #1603 (4850cfe) into master (5bbae00) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1603   +/-   ##
=========================================
  Coverage     80.96%   80.96%           
  Complexity      843      843           
=========================================
  Files            72       72           
  Lines          2506     2506           
  Branches        352      352           
=========================================
  Hits           2029     2029           
  Misses          365      365           
  Partials        112      112           

codecov[bot] avatar Oct 12 '22 12:10 codecov[bot]

@timja So sorry for the 1.5 years-ish long delay. Can you please re-review whenever you have time, thanks for being so patient!

dheerajodha avatar Oct 12 '22 13:10 dheerajodha

@jetersen is it possible to disable LGTM? it's getting shutdown anyway

timja avatar Oct 13 '22 07:10 timja

Feel free to open PR

jetersen avatar Oct 13 '22 07:10 jetersen

Feel free to open PR

is it in this repo? I couldn't see anything

timja avatar Oct 13 '22 11:10 timja

I've removed it from https://github.com/organizations/jenkinsci/settings/installations/1577539

timja avatar Oct 13 '22 11:10 timja