configuration-as-code-plugin icon indicating copy to clipboard operation
configuration-as-code-plugin copied to clipboard

Vault secrets engine: Choose to abort config reloads if secrets cannot be resolved

Open ninjaMog opened this issue 5 years ago • 0 comments

Your checklist for this issue

🚨 Please review the guidelines for contributing to this repository.

  • [x] Link to any upstream changes that might be required (for example Jenkins Core pull request)

Feature Request

When using the Vault secrets engine, if secret placeholders cannot be resolved (invalid secret / vault unavailable / access denied / other reasons) they are replaced with an empty string.

This can have catastrophic consequences, as a working Jenkins instance can suddenly have all it's credentials replaced with empty values if the vault server is not available (e.g. if there is a temporary connectivity issue)

This behaviour is stopping us adopting vault as our configuration as code secrets engine.

If we could enable a flag which aborted configuration reloads rather than continuing with the configuration update, this would resolve our problem.

Other suggestions most welcome!

ninjaMog avatar Jul 22 '20 16:07 ninjaMog