configuration-as-code-plugin icon indicating copy to clipboard operation
configuration-as-code-plugin copied to clipboard

Add json schema validation to RoundTripAbstractTest

Open timja opened this issue 6 years ago • 4 comments

https://github.com/jenkinsci/configuration-as-code-plugin/blob/1009f950babffb896a67f9ebae3d07cfcf537f5f/plugin/src/test/java/io/jenkins/plugins/casc/misc/RoundTripAbstractTest.java#L47

RoundTripAbstractTest should be updated to validate the json schema as well

timja avatar Sep 29 '19 20:09 timja

FYI @MRamonLeon

oleg-nenashev avatar Sep 29 '19 21:09 oleg-nenashev

@timja Would adding one of the schema.validate("filename") functions be sufficient here? In the sense validation before application ?

sladyn98 avatar Oct 01 '19 19:10 sladyn98

@timja Would adding one of the schema.validate("filename") functions be sufficient here? In the sense validation before application ?

not quite sure, but basically what you've done in your testing PR but adding a call to this in the uber abstract test

timja avatar Oct 02 '19 07:10 timja

So basically call the function from this test ?

sladyn98 avatar Oct 02 '19 09:10 sladyn98