config-file-provider-plugin icon indicating copy to clipboard operation
config-file-provider-plugin copied to clipboard

support for proxy authentication fill-in added

Open sealor opened this issue 7 years ago • 8 comments

When providing maven settings and global maven settings the proxy authentication is now also filled in using the Jenkins credentials if available. The feature is similar to the authentication replacements for maven server configurations.

See https://maven.apache.org/settings.html

sealor avatar Sep 06 '18 16:09 sealor

@imod Do we need to create an JIRA issue before sending a pull-request? We are longingly waiting for this proxy feature ;-)

sealor avatar Sep 25 '18 16:09 sealor

@sealor its not required per se, but it helps a lot to get more context about the issue you try to solve

imod avatar Oct 01 '18 09:10 imod

It would be great to get this merged

jonfreedman avatar Jul 18 '19 11:07 jonfreedman

@sealor I'm sure this will work, but from a users point of view, this is a hidden feature. To make this more visible (and clean), there should probably be a "Proxy Credentials" section beside the "Server Credentials" Section when editing a configuration.

this comes even more apparent when you look at the way this would look when creating a configfile with the job-dsl plugin:

configFiles {
    mavenSettingsConfig {
        id('DEFAULT_MAVEN_SETTINGS')
        name('default maven settings')
        comment('default settings for yooture projects')
        content(readFileFromWorkspace('config-files/maven-settings.xml'))
        isReplaceAll(true)
        serverCredentialMappings {
            serverCredentialMapping {
                serverId('private-release')
                credentialsId('MYUSER_MAVEN')
            }
            serverCredentialMapping {
                serverId('private-snapshot-repository')
                credentialsId('MYUSER_MAVEN_SNAPSHOT')
            }
        }        
    }
}

imod avatar Dec 23 '19 12:12 imod

@imod Now, there is a "Proxy Credentials" section beside the "Server Credentials" section. The new feature behaves exactly like the other one.

sealor avatar Feb 15 '20 21:02 sealor

@MRamonLeon Why did you close this pull request?

I myself do not need this feature anymore because I now use another solution. But in my opinion this feature would be very helpful for others.

sealor avatar Apr 25 '21 08:04 sealor

@sealor I was scrubbing a bit and I probably misunderstood your last comment and taking into account the last time it had activity I closed it. Happy to reopen if it's still interesting. I can't commit to any review ATM though.

MRamonLeon avatar Apr 26 '21 10:04 MRamonLeon

@MRamonLeon Thank you for re-opening this issue! I did not know that there are conflicting files now. I plan to resolve them.

sealor avatar Apr 26 '21 19:04 sealor