conditional-buildstep-plugin icon indicating copy to clipboard operation
conditional-buildstep-plugin copied to clipboard
verified publisher icon jenkinsci

Adding else and if-else support

Open SanjayThomas opened this issue 7 years ago • 6 comments

Hello All,

I had seen the ER for enabling else support for the conditional builds step plugin: https://issues.jenkins-ci.org/browse/JENKINS-20292?src=confmacro

I have also added if-else support as part of the ER as I had seen this request in a duplicate ER of the above-mentioned one. Link to this: https://issues.jenkins-ci.org/browse/JENKINS-25918

Hope this implementation is satisfactory.

SanjayThomas avatar Feb 24 '18 20:02 SanjayThomas

@SanjayThomas sorry for missing this, I will take a look a it as soon as I find time

imod avatar May 14 '18 04:05 imod

The earlier failure was due to the test case trying to open a Unix shell while testing in WIndows. Modified the test case to use BatchFile when running on Windows.

SanjayThomas avatar Oct 06 '18 08:10 SanjayThomas

@imod Could you take a look at this? Please let me know if I've missed something here.

SanjayThomas avatar Dec 27 '18 02:12 SanjayThomas

I am tempted to land it, but I would like to firstly integrate https://github.com/jenkinsci/conditional-buildstep-plugin/pull/21 which is quite an emergency for the new weekly releases

oleg-nenashev avatar Nov 11 '20 21:11 oleg-nenashev

@oleg-nenashev please feel free to do so - I'm currently very short in time and will not be able to do so in any foreseeable time

imod avatar Nov 13 '20 07:11 imod

This PR will need an update after the recent tables to divs patches. Added to my queue, no ETA :(

oleg-nenashev avatar Dec 10 '20 18:12 oleg-nenashev