build-monitor-plugin icon indicating copy to clipboard operation
build-monitor-plugin copied to clipboard

Feature: include/exclude branches of multi-branch pipelines

Open reftel opened this issue 8 years ago • 7 comments

Closes #246

reftel avatar Oct 14 '16 21:10 reftel

Updated as suggested. Also added some tests to show how the include/exclude branch rules work.

reftel avatar Oct 18 '16 20:10 reftel

Hey @reftel, I've just run the local build (mvn clean verify) and am seeing the acceptance tests failing for all the scenarios that don't use the Folders plugin (such as those here):

2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher - Caused by: java.lang.NullPointerException
2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher -   at hudson.Util.filter(Util.java:104)
2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher -   at com.smartcodeltd.jenkinsci.plugins.buildmonitor.JobFilter.filterJobs(JobFilter.java:37)
2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher -   at com.smartcodeltd.jenkinsci.plugins.buildmonitor.BuildMonitorView.jobViews(BuildMonitorView.java:161)
2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher -   at com.smartcodeltd.jenkinsci.plugins.buildmonitor.BuildMonitorView.fetchJobViews(BuildMonitorView.java:150)
2016-10-27 17:52:05:075 +0100 [jenkins] DEBUG JenkinsLogWatcher -   ... 61 more

Looks like the filter(...) doesn't like to be given nulls. Would you mind taking a look?

Thanks, J

jan-molak avatar Oct 27 '16 16:10 jan-molak

Now handling nulls up to 15% better - or more!

reftel avatar Oct 27 '16 17:10 reftel

Hey @reftel, I just had another look at the PR and it looks like the following acceptance test is now failing due to the JobFilter producing duplicates if there are jobs nested in folders and sub-folders.

I'll try to look into what might be causing this problem.

J

jan-molak avatar Nov 03 '16 12:11 jan-molak

@jan-molak anything i can do to speed this PR up? :)

sazo avatar Jul 04 '17 13:07 sazo

@reftel do you have an ETA on this?

arnemertz avatar Jan 09 '18 08:01 arnemertz

@reftel @jan-molak can we have an update on this?

erikhakansson avatar Apr 11 '18 08:04 erikhakansson