Build Status not propagating to Bitbucket On Prem

[cyberemissary]

As of the security fix in 2.8.4 the build status notifications stopped propagating to our bitbucket server.

It might be something to do with clone links, our repo is configured to only allow ssh clone, so this code fragment seems to not set the base url as it is restricted by the http check

Relevant part of hook payload:

 "links": {
          "clone": [
            {
              "href": "ssh://[email protected]/path/to/repo.git",
              "name": "ssh"
            }
          ],
          "self": [
            {
              "href": "https://ourhost.com/users/user/repos/reponame/browse"
            }
          ]
        }

[cyberemissary]

I think, I could create a PR for this but need to know if we should fallback to the "self" link or try to build a base url from the SSH one. If SSH one should we force it to be SSL?

[julioc-p]

I would love to dig into this issue further

[julioc-p]

A new field will be added to specify the url to propagate. The self link cannot be used since it is a security risk.