bitbucket-branch-source-plugin
bitbucket-branch-source-plugin copied to clipboard
jenkinsci
Refresh Credentials
Instead of storing credentials, store reference to credentials and retrieve them as needed.
Fix for https://github.com/jenkinsci/bitbucket-branch-source-plugin/issues/331
NOTE: this is a draft - no tests or even comments yet - just wanted you to review this.
Your checklist for this pull request
- [x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or in Jenkins JIRA
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Did you provide a test-case? That demonstrates feature works or fixes the issue.
@mlasevich Could you fix the static analysis failures in this PR? Then people could more easily try this via the incremental build and see if it addresses their issue.
2020-07-30T09:26:17.081Z] [ERROR] Class com.cloudbees.jenkins.plugins.bitbucket.BitbucketTeamMetadataAction$BitbucketAvatarCacheSource defines non-transient non-serializable instance field bbCredentials [com.cloudbees.jenkins.plugins.bitbucket.BitbucketTeamMetadataAction$BitbucketAvatarCacheSource] In BitbucketTeamMetadataAction.java SE_BAD_FIELD
(And this would be one reason to not pass bbCredentials. 😄
Incremental: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/cloudbees-bitbucket-branch-source/2.9.2-rc646.4d8a581fc810/
Would be great to have this in when ready, suffering from this issue at the moment!
done in a different way here https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/637
