aws-secrets-manager-credentials-provider-plugin icon indicating copy to clipboard operation
aws-secrets-manager-credentials-provider-plugin copied to clipboard

Fix forward slash character handling in credential IDs

Open chriskilding opened this issue 3 years ago • 1 comments
trafficstars

Fix forward slash character handling in credential IDs, so that they can be displayed in the Web UI without breaking

Fixes #205

chriskilding avatar Jun 23 '22 14:06 chriskilding

The basic idea will be to wrap the credentials with the CredentialsWrapper proxy class.

This includes the magic ingredient

public String getUrlName() {
            return Util.rawEncode(id);
}

Which urlencodes the credential ID, making any forward slash characters within it safe.

But we need to figure out how the CredentialsWrapper is passed around and used.

chriskilding avatar Jun 23 '22 14:06 chriskilding

Closing as this is a problem across all credential providers (including the default one) - not just this one - so it's not something that can be fixed here.

chriskilding avatar Jan 17 '23 13:01 chriskilding