aws-secrets-manager-credentials-provider-plugin icon indicating copy to clipboard operation
aws-secrets-manager-credentials-provider-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

fix: Use fingerprint icon from core

Open NotMyFault opened this issue 3 years ago • 3 comments

The change proposed utilizes the corresponding icon from core, which respects themes properly. Current implementation on dark mode: Bildschirmfoto 2022-06-23 um 00 36 29 Proposed change: Bildschirmfoto 2022-06-23 um 00 39 23

cc @chriskilding

NotMyFault avatar Jun 22 '22 22:06 NotMyFault

@NotMyFault do you know which Jenkins version introduced the new icon?

This plugin currently has a base of

  • Jenkins 2.289
  • Parent POM 2.40
  • BOM 1461.vb_3c6de28f2b_a_

So I want to avoid the possibility of introducing an 'icon not found' error if these aren't new enough.

chriskilding avatar Jun 28 '22 16:06 chriskilding

@NotMyFault I have brought the BOM dependency up to date to bring in the latest credentials-plugin version. It appears that BasicSSHUserPrivateKey now uses symbol-fingerprint for its icon - not icon-fingerprint as in this PR.

Is it ok to use symbol-fingerprint instead?

chriskilding avatar Jul 18 '22 16:07 chriskilding

Yes, apparently I lost track of the PR, apologizes.

Keep in mind that Jenkinsfile modifications on my fork don't modify the Jenkinsfile revisions the PR build uses, hence the build uses 2.289.3 still.

NotMyFault avatar Jul 18 '22 16:07 NotMyFault

This may also fix #246

chriskilding avatar Oct 31 '22 18:10 chriskilding