aws-secrets-manager-credentials-provider-plugin icon indicating copy to clipboard operation
aws-secrets-manager-credentials-provider-plugin copied to clipboard

Added Github App Credentials support

Open trispad opened this issue 2 years ago • 8 comments

@jon-schuck-MA added support for Github App Credentials from the github-branch-source plugin. The github-branch-source plugin is optional and the credentials will only will be created when the plugin is installed.

I am attempting to take their work from #87 to done.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

trispad avatar Mar 03 '22 17:03 trispad

it would be awesome to get this one merged, is there anything that's missing? I can try to help if so

julio-je-yaguez avatar Jul 05 '22 07:07 julio-je-yaguez

Looks like there are some conflicts now due to changes from v1.2.0. Once this is integrated and tested we need :eyes: from the maintainers.

trispad avatar Jul 05 '22 14:07 trispad

Hey I would also add my help here to get this one merged and released :)

Larusso avatar Aug 31 '22 10:08 Larusso

Hello, do you have ETA?

denis-matchenko avatar Dec 15 '22 15:12 denis-matchenko

@trispad, we could really do with making us of those one, let me know if there's anything I can do to help get this over the line, it looks like it's nearly there!

tomcart90 avatar May 26 '23 12:05 tomcart90

@tomcart90 - What would be helpful is re-integrating this with the mainline. There were some changes made to main that need to be addressed in this PR. If you could do it I would be appreciative.

trispad avatar Jul 17 '23 13:07 trispad

Guys, any progress with that?

asaf-the-ancient avatar Feb 01 '24 09:02 asaf-the-ancient

hello team, also would like to know, any updates?

nickhuang016 avatar Apr 10 '24 07:04 nickhuang016