appcenter-plugin icon indicating copy to clipboard operation
appcenter-plugin copied to clipboard

Removed 1 unnecessary stubbing in RemoteFileUtilsTest.java

Open ARUS2023 opened this issue 2 years ago • 0 comments

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

In our analysis of the project, we observed that: 1 stubbing in RemoteFileUtilsTest.setUp is created but never executed by 16 tests RemoteFileUtilsTest.should_ReturnContentType_When_APK, RemoteFileUtilsTest.should_ReturnContentType_When_AAB, RemoteFileUtilsTest.should_ReturnContentType_When_MSI, RemoteFileUtilsTest.should_ReturnContentType_When_PLIST, RemoteFileUtilsTest.should_ReturnContentType_When_AETX, RemoteFileUtilsTest.should_ReturnContentType_When_CER, RemoteFileUtilsTest.should_ReturnContentType_When_XAP, RemoteFileUtilsTest.should_ReturnContentType_When_APPX, RemoteFileUtilsTest.should_ReturnContentType_When_APPXBUNDLE, RemoteFileUtilsTest.should_ReturnContentType_When_APPXUPLOAD, RemoteFileUtilsTest.should_ReturnContentType_When_APPXSYM, RemoteFileUtilsTest.should_ReturnContentType_When_MSIX, RemoteFileUtilsTest.should_ReturnContentType_When_MSIXBUNDLE, RemoteFileUtilsTest.should_ReturnContentType_When_MSIXUPLOAD, RemoteFileUtilsTest.should_ReturnContentType_When_MSIXSYM, RemoteFileUtilsTest.should_ReturnContentType_When_UNKNOWN.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

ARUS2023 avatar Oct 06 '23 02:10 ARUS2023