[FIXED JENKINS-49057] List All Options for Ansible Playbook Pipeline Syntax Generator

[michaelcresswell]

extraVariables and inventoryContent have been added to the generator extraVars is deprecated since maps do not work with the generator

[michaelcresswell]

I think this one requires closer review. Sirot seemed to go out of his way to expose extraVars as a map instead of a list like the freestyle jobs use but it's not clear to me why he did that. I see three possible approached for including extra variables in the syntax generator:

1. Expose extraVars as a list instead of a map
   • This breaks the API so existing extraVar users would need to update their pipelines
   • It was never well documented so not sure how big this impact is
2. Expose a new variable as a list and leave the map version off the generator
3. Expose the map through the generator, possibly with a different UI than freestyle jobs
   • I attempted this idea but couldn't get the generator to create the map

f168654 implements Option 2

@escoem Any feedback?

[escoem]

Hi @michaelcresswell I'm sorry because of the delay but has been motivated by https://jenkins.io/security/advisory/2018-03-26/

I will review as soon as possible. Thanks a lot as always Michael.