android-emulator-plugin icon indicating copy to clipboard operation
android-emulator-plugin copied to clipboard

Outside package

Open Bresiu opened this issue 9 years ago • 4 comments

Bresiu avatar Sep 04 '15 14:09 Bresiu

Sounds good, but please resubmit without all the formatting changes.

Sorry I can't review the code just now; I'll check it out when I get a chance next week.

orrc avatar Sep 04 '15 14:09 orrc

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

jenkinsadmin avatar Sep 04 '15 18:09 jenkinsadmin

I reverted formatting changes but there are few issues to consider.

  1. Not only crashes but also ANRs originating outside tested package should be ignored.
  2. Differentiating between tested and "outside" package should be performed for each series separately. Now eg. if monkey output contains log from testing packages A and B, if test of package A has completed without issues and package B crashed during its own test then result will be falsely equal to success.
  3. Consider case when launcher app (outside one) crashes after injecting 3 of 1000 events to tested app. With current code it will be treated as success which does not sound good. One of the solutions may be:
  • add all --ignore-* options to monkey command line, so it won't stop when it detects crash or ANR (it may come outside a tested package)
  • if counters of finishes and injected events matches their expected values then scan each series for crashes and ANR ignoring ones coming from outside a tested package

koral-- avatar Sep 06 '15 22:09 koral--

What is happening with this PR? Should we merge / close it?

Bresiu avatar Feb 15 '19 10:02 Bresiu