analysis-model icon indicating copy to clipboard operation
analysis-model copied to clipboard

DIP conformity for ModuleDetector

Open mkapra opened this issue 3 years ago • 2 comments

Adjust the ModuleDetector to be conform with the DIP principle. Also add the class diagrams from the beginning and after the remodelling.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

mkapra avatar Oct 12 '21 19:10 mkapra

@uhafner Looks like a failure on the linux host of the action causes the failure.

mkapra avatar Oct 14 '21 20:10 mkapra

Codecov Report

Merging #693 (c2672d6) into master (2575145) will increase coverage by 0.02%. The diff coverage is 97.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #693      +/-   ##
============================================
+ Coverage     92.62%   92.65%   +0.02%     
- Complexity     2080     2092      +12     
============================================
  Files           307      312       +5     
  Lines          5807     5827      +20     
  Branches        583      585       +2     
============================================
+ Hits           5379     5399      +20     
  Misses          265      265              
  Partials        163      163              
Impacted Files Coverage Δ
...ava/edu/hm/hafner/analysis/OsgiModuleDetector.java 92.30% <92.30%> (ø)
...edu/hm/hafner/analysis/AbstractModuleDetector.java 100.00% <100.00%> (ø)
...java/edu/hm/hafner/analysis/AntModuleDetector.java 100.00% <100.00%> (ø)
...a/edu/hm/hafner/analysis/GradleModuleDetector.java 100.00% <100.00%> (ø)
...va/edu/hm/hafner/analysis/MavenModuleDetector.java 100.00% <100.00%> (ø)
...in/java/edu/hm/hafner/analysis/ModuleDetector.java 96.77% <100.00%> (+0.13%) :arrow_up:
.../java/edu/hm/hafner/analysis/PackageDetectors.java 90.00% <100.00%> (-2.31%) :arrow_down:
...va/edu/hm/hafner/analysis/PackageNameResolver.java 95.65% <100.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2575145...c2672d6. Read the comment docs.

codecov[bot] avatar Oct 14 '21 21:10 codecov[bot]