active-choices-plugin icon indicating copy to clipboard operation
active-choices-plugin copied to clipboard
verified publisher icon jenkinsci

[JENKINS-72282] apply Jenkins styling to selects, radios and checkboxes

Open mawinter69 opened this issue 10 months ago • 3 comments

The change will make active choice and active reactive choice parameters take the current Jenkins stylings.

New look:

image

additional changes:

  • moved all inline styling from attributes to css file
  • removed the transitionWrapper taglib, we are now always on div based layout

Testing done

Interactive testing

Submitter checklist

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

mawinter69 avatar Feb 15 '25 00:02 mawinter69

Or.... maybe it'd be possible to use css/scss to copy the jenkins styles to the current DOM layout. Can't tell if that'd be a good idea, nor easy to implement, but that's an alternative, I think.

kinow avatar Feb 15 '25 07:02 kinow

I have now adjusted the js code so it also renders the elements properly, at least for CascadeParameter. Tests are green now. Still need to validate the dynamic case

mawinter69 avatar Feb 15 '25 18:02 mawinter69

sure, no problem to wait with this one. From my side everything is fine. I had some questions though where if my assumption is wrong some changes might be required.

mawinter69 avatar Mar 01 '25 16:03 mawinter69

Rebased, conflicts fixed, and commits squashed.

kinow avatar Jul 27 '25 18:07 kinow

Thanks for this PR

A release would be very much appreciated

By the way I would be very helpful to have release notes updated (https://issues.jenkins.io/browse/JENKINS-75963)

Regards,

jonesbusy avatar Aug 05 '25 08:08 jonesbusy

Thanks @jonesbusy , note taken. The changelog should be easy to fix.

As for the release, there is a bug affecting every Chrome user, and another issue that I just need some time to investigate it and confirm if we can skip it, or if it's a must for this release. Just pending on either a PR for the chrome bug and someone reviewing the issues updated since last release, or I having some time to volunteer on that (summer here in EU, so covering for others that are on holidays, and soon going on some holidays myself).

kinow avatar Aug 05 '25 08:08 kinow

No problem, I just noticed the UI issue this morning

choice_parameter

jonesbusy avatar Aug 05 '25 08:08 jonesbusy