acceptance-test-harness icon indicating copy to clipboard operation
acceptance-test-harness copied to clipboard

the WebDriver may be wrapped so we also need to unwrap it

Open jtnord opened this issue 2 years ago • 1 comments

The WebDriver may be wrapped or unwrapped so we need to unwarp it to get the underlying driver to see if that is a RemoteWebDriver to configure the FileDetector

amends #884

  • [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ ] Ensure that the pull request title represents the desired changelog entry
  • [ ] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

jtnord avatar Aug 15 '22 17:08 jtnord

Build failure is real

Setting the file detector only works on remote webdriver instances obtained via RemoteWebDriver

jtnord avatar Aug 15 '22 20:08 jtnord

this appears to be a regression in the weekly at some point.

The dialog is not removed correctly - firstly the buttons are remoed, then the background styling and sometime later the fields etc. this is visibly slow and causing screen redraw, whereas on the LTS the button and dialog seem to disappear "as one"

jtnord avatar Aug 16 '22 16:08 jtnord

2.358 is ok 2.359 fails

jtnord avatar Aug 16 '22 16:08 jtnord

plugins.SshSlavesPluginTest.connectWithKey is flaky (more so with recent cores) but I believe this is now well and truly fixed... a0bbd06a382e9903b6d795daaba18f24432fca44

jtnord avatar Aug 16 '22 19:08 jtnord