jenkins-cli icon indicating copy to clipboard operation
jenkins-cli copied to clipboard

Add a new feature which upgrades jenkins and plugin in a docker container

Open jxr98 opened this issue 3 years ago • 5 comments

Make sure that you've checked the boxes below before you submit PR:

Always

  • [x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • [ ] Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

  • [ ] Quality Gate Passed. Change this URL to your PR.
  • [ ] The coverage is xxx on the new lines
  • [ ] I've tested it by manual in the following platform
    • [ ] MacOS
    • [x] Linux
    • [ ] Windows
  • [ ] Unit Test covered
  • [ ] e2e Test covered

jxr98 avatar Aug 08 '21 08:08 jxr98

Codecov Report

Merging #608 (2b2bd2d) into master (8f2c9f0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12           
Flag Coverage Δ
unittests 37.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f2c9f0...2b2bd2d. Read the comment docs.

codecov-commenter avatar Aug 08 '21 08:08 codecov-commenter

This function is based on the Docker SDK provided for golang. To use it, you need to have docker installed locally or remotely. For example. if you have docker installed on another server 209.250.235.50 and expose the Docker Daemon with -H tcp://0.0.0.0:2375, you can pass --docker-ip 209.250.235.50 (you don't need to point the port cuz the default port is 2375). If you have docker installed locally, you can pass --docker-ip 127.0.0.1 or sth else. When Docker and war file are both available, this function will build a image(default name is test and you can change it), create a container and start the container.

jxr98 avatar Sep 05 '21 01:09 jxr98

@jxr98 If you are sure you have completed this function, please delete WIP for the title.

yJunS avatar Sep 05 '21 04:09 yJunS

@jxr98 If you are sure you have completed this function, please delete WIP for the title.

Oops. I forgot.

jxr98 avatar Sep 05 '21 04:09 jxr98

can you just give me an example of the usage?

Of Course. This start_jenkins.go is used in annother function which I haven't created a pull request for, but I have done most of the work. I am editing some of the prs. I am gonna show you very soon.

jxr98 avatar Sep 27 '21 14:09 jxr98