jenkins-cli icon indicating copy to clipboard operation
jenkins-cli copied to clipboard

Hook comand shouldn't always executes even there's error exists

Open LinuxSuRen opened this issue 5 years ago • 6 comments

Describe the bug Part of my config is below.

postHooks:
- path: plugin.upload
  cmd: jcli center watch --util-install-complete
- path: plugin.upload
  cmd: jcli restart -b

The command should stop if one of the preHooks is failed.

To Reproduce Steps to reproduce the behavior:

  1. Add the sample which I given into you config file
  2. Execute command jcli upload under a plugin project source directory
  3. See the result

Expected behavior The command should not be executed once if there's some thing wrong.

Screenshots None.

Desktop (please complete the following information):

  • OS: MacOS
  • Version: dev-v0.0.19

Additional context None.

LinuxSuRen avatar Sep 17 '19 01:09 LinuxSuRen

I will be working on this

waveywaves avatar Oct 15 '19 12:10 waveywaves

@waveywaves Great! I'm going to assign this to you. And thanks for your enthusiasm.

LinuxSuRen avatar Oct 15 '19 12:10 LinuxSuRen

Hi @waveywaves , just a kind reminder. Are you still interested in this?

LinuxSuRen avatar Nov 02 '19 11:11 LinuxSuRen

Yes, I have started working on it.

waveywaves avatar Nov 03 '19 22:11 waveywaves

Great, take it easy. I'm looking forward to it.

LinuxSuRen avatar Nov 04 '19 00:11 LinuxSuRen

hi @waveywaves , how is it going? Do you need help from me?

LinuxSuRen avatar Dec 08 '19 07:12 LinuxSuRen