terraform-aws-eks-jx
terraform-aws-eks-jx copied to clipboard
jenkins-x
fix: add vpc outputs
Hi @ajp-lqx. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign dgozalo
You can assign the PR to them by writing /assign @dgozalo in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Need to re-generate readme file.
terraform-docs markdown table .
Also, would be awesome to just add a basic check to see if subnets were indeed created: https://github.com/jenkins-x/terraform-aws-eks-jx/blob/master/test/terraform_eks_test.go
We use the jx3 example repo for testing purposes: https://github.com/jenkins-x/terraform-aws-eks-jx/tree/master/examples/jx3 (you can update the output.tf with the vpc output)
@ajp-lqx: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pr-build | ca643f0989cb87262bebb05a56fd09fa04d0414d | link | /test this |
View all Builds for this Pull Request
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale
