jx-docs icon indicating copy to clipboard operation
jx-docs copied to clipboard

feat: Add docs for https://github.com/jenkins-x/lighthouse/pull/1424

Open keskad opened this issue 2 years ago • 4 comments

Docs for https://github.com/jenkins-x/lighthouse/pull/1424

Signed-off-by: Damian Kęska [email protected]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • [ ] I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • [x] I have signed off the commit, as per instructions mentioned here.
  • [ ] Any dependent changes have already been merged.

keskad avatar Mar 12 '22 11:03 keskad

Hi @keskad. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

jenkins-x-bot avatar Mar 12 '22 11:03 jenkins-x-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pmuir You can assign the PR to them by writing /assign @pmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jenkins-x-bot avatar Mar 12 '22 11:03 jenkins-x-bot

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Mar 12 '22 11:03 sonarcloud[bot]

Maybe not in scope of this PR but after it I would add docs how to create secrets, roles and service accounts for additional namespaces. The key is that for each namespace admin would like to have separate secrets, because it is all about the security and separation, least privileges.

keskad avatar Mar 12 '22 11:03 keskad