jx-docs
jx-docs copied to clipboard
jenkins-x
feat: add ability to enlarge image on click
fixes #3089 @ankitm123 i have tried to make it work. please guide me what changes i need to do and where i am wrong. as i am new with this kind of codebase
Hi @khushishikhu. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Couple of points:
- the Commit message format checks fail - you need to change your commit message and PR title to match the semantic convention, see https://jenkins-x.io/community/code/#the-commit-message
IMHO, this is a new feature, so the apt title would be:
feat: add ability to enlarge image on click
or some thing similar. You just need to change the PR title and the commit message.
- Update the PR description to add
fixes #3089https://github.com/jenkins-x/jx-docs/pull/3100#issue-506992070. This way when the PR is merged, the issue will be automagically closed.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and 
0 Security Hotspots to review)
0 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
seeing 404 for the js files in the dev console.
@ankitm123 can you please tell me when can you put here label for hacktoberfest-accepted
@ankitm123 can you please tell me when can you put here label for hacktoberfest-accepted
@MarckK Any idea what this means? @khushishikhu is it just a label for this PR/issue? If yes, I can do it.
@ankitm123 yes, it's just a label, see https://hacktoberfest.digitalocean.com/hacktoberfest-update
@ankitm123 can you please tell me when can you put here label for hacktoberfest-accepted
@MarckK Any idea what this means? @khushishikhu is it just a label for this PR/issue? If yes, I can do it.
Actually yes @ankitm123 just like the linked issue has a label for hacktoberfest. According to those guidelines the PR will be considered for completing the challenge when it has hacktoberfest-accepted label or that pr has been approved or merged.
Actually yes @ankitm123 just like the linked issue has a label for hacktoberfest. According to those guidelines the PR will be considered for completing the challenge when it has hacktoberfest-accepted label or that pr has been approved or merged.
Done
@ankitm123 sorry i have been bit busy with my collage. but here is the problem i facing that i tried to make another html file but its not supporting or i should put the code in an existing html file. Because i didn't find any relatable html file with maturity-matrix where shortcodes should be written. please help me to solve this issue
@ankitm123 sorry i have been bit busy with my collage. but here is the problem i facing that i tried to make another html file but its not supporting or i should put the code in an existing html file. Because i didn't find any relatable html file with maturity-matrix where shortcodes should be written. please help me to solve this issue
I will get back to you by EOD. Thanks for working on this :+1:
So short codes are normally defined here. An example of using a shortcode is: https://github.com/jenkins-x/jx-docs/blob/master/content/en/v3/admin/platforms/_index.md (look at {{
failed to trigger Pull Request pipeline
- failed to create agent
- failed to calculate in repo config
- failed to create trigger config from local source for repo jenkins-x/jx-docs ref 1eb052a403af8d2539f7254a3ee7b3d24c3b6f6f
- failed to find any lighthouse configuration files in repo jenkins-x/jx-docs at sha 1eb052a403af8d2539f7254a3ee7b3d24c3b6f6f
- Not Found
failed to trigger Pull Request pipeline
- failed to create agent
- failed to calculate in repo config
- failed to create trigger config from local source for repo jenkins-x/jx-docs ref 132a675573d007c65e3030d1566d683649be5dfa
- failed to find any lighthouse configuration files in repo jenkins-x/jx-docs at sha 132a675573d007c65e3030d1566d683649be5dfa
- Not Found
SonarCloud Quality Gate failed.
6 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
can you rebase the PR? There were some changes to the pipeline. Basically,
- checkout master branch of ur fork (ensure that ur master branch is in sync with the jx-docs master branch)
- git pull
- go back to
patch-1branch, and rebase:git checkout patch-1 && git rebase master - fix the merge conflicts and push back.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale
