jx-docs icon indicating copy to clipboard operation
jx-docs copied to clipboard

Enlarge images when users click on them

Open ankitm123 opened this issue 4 years ago • 27 comments

This is a Feature Request

What would you like to be added I would like to have a zoom in feature for images in the doc site, just like medium. So, when a user hovers over an image, it allows an user to click on the image to enlarge it.

Why is this needed The text in the maturity matrix for jenkins X post 3.0 alpha really looks small, and is hard for readers to see. https://jenkins-x.io/docs/v3/about/maturity-matrix/

Comments There is a js library which does this: https://github.com/francoischalifour/medium-zoom. A good discussion on how to implement it in hugo can be found here: https://discourse.gohugo.io/t/image-js-zoom-script/27325/5

ankitm123 avatar Oct 12 '20 13:10 ankitm123

may i work on this

khushishikhu avatar Oct 12 '20 16:10 khushishikhu

@khushishikhu Awesome, please assign it to urself, by typing:

/assign

ankitm123 avatar Oct 12 '20 16:10 ankitm123

/unassign /assign @khushishikhu

ankitm123 avatar Oct 12 '20 16:10 ankitm123

@ankitm123 can you please give me any reference for setting up this repository locally

khushishikhu avatar Oct 17 '20 18:10 khushishikhu

@khushishikhu you could refer to the instructions mentioned in README.md. Feel free to ping in case you notice any step is not clear or not working.

borntorock avatar Oct 19 '20 11:10 borntorock

@ankitm123 can you please give me any reference for setting up this repository locally

https://jenkins-x.io/community/documentation/#docker-compose-method

ankitm123 avatar Oct 19 '20 11:10 ankitm123

Capture i am just trying to run this repository locally but struck on this warning. i don't know how as i have installed all the prerequisite. please help me to resolve it.

khushishikhu avatar Oct 20 '20 19:10 khushishikhu

@khushishikhu Would be better to use docker-compose instead of installing dependencies directly on ur system. Was there any issue with the docker-compose approach (https://github.com/jenkins-x/jx-docs/issues/3089#issuecomment-712107687)?

ankitm123 avatar Oct 20 '20 19:10 ankitm123

@khushishikhu Would be better to use docker-compose instead of installing dependencies directly on ur system. Was there any issue with the docker-compose approach (#3089 (comment))?

yes @ankitm123 i tried to use docker but then my system hangs a lot so i am just not comfortable with docker. That's why i was installing dependencies directly

khushishikhu avatar Oct 21 '20 02:10 khushishikhu

So looking at ur error, it seems you are on a windows machine, and hence make does not work. Any chance you could use windows subsystem for linux? https://docs.microsoft.com/en-us/windows/wsl/install-win10 If not, I have to update the docs for windows contributors (we only have instructions for unix-like systems)

ankitm123 avatar Oct 21 '20 11:10 ankitm123

So looking at ur error, it seems you are on a windows machine, and hence make does not work. Any chance you could use windows subsystem for linux? https://docs.microsoft.com/en-us/windows/wsl/install-win10 If not, I have to update the docs for windows contributors (we only have instructions for unix-like systems)

yes @ankitm123 i can use ubuntu. can you please give me the instruction link for that.

khushishikhu avatar Oct 21 '20 12:10 khushishikhu

https://github.com/jenkins-x/jx-docs#locally, basically make server should work for ubuntu, after you install the version of hugo mentioned in the makefile

ankitm123 avatar Oct 23 '20 01:10 ankitm123

Capture @ankitm123 i don't know why but it is not excepting the hugo version 0.76.5

khushishikhu avatar Oct 23 '20 08:10 khushishikhu

We are still on hugo version 0.74.0 (https://github.com/jenkins-x/hugo-extended-docker/blob/master/HUGO_VERSION), probably worth upgrading, but not in this PR (You can always create another PR to upgrade it).

So, for now, install version 0.74.0 (https://github.com/gohugoio/hugo/releases/tag/v0.74.0) of hugo, and run make server again. Remove ur exisiting version of hugo. Download the hugo extended version from assets section (https://github.com/gohugoio/hugo/releases/download/v0.74.0/hugo_extended_0.74.0_Linux-64bit.deb) and install the debian file (https://unix.stackexchange.com/a/159114)

Now that ur using ubuntu, my recommendation would be to see if docker-compose is stable on ur ubuntu system or not. As you can already see, it abstracts away all of the headache associated with installing hugo locally.

ankitm123 avatar Oct 23 '20 09:10 ankitm123

https://github.com/jenkins-x/jx-docs/blob/master/Makefile#L1 -> the makefile does a check against this version of hugo, hence you see the error.

ankitm123 avatar Oct 23 '20 10:10 ankitm123

Capture @ankitm123 i was using docker on ubuntu and i guess it is almost done but the server is not running. can you please look at this issue and help me to resolve it. Thank you for your guidance.

khushishikhu avatar Oct 23 '20 11:10 khushishikhu

@ankitm123 i was using docker on ubuntu and i guess it is almost done but the server is not running. can you please look at this issue and help me to resolve it. Thank you for your guidance.

Can you post the output of docker-compose logs -f server? Also what do u see when u navigate to http://localhost:1313/?

ankitm123 avatar Oct 23 '20 12:10 ankitm123

Capture now it's running well. after running this command docker-compose logs -f server. Thank you!!

khushishikhu avatar Oct 23 '20 12:10 khushishikhu

It was working when u ran make compose-up (the server runs in the background fyi), the log command was to just see the logs (and debug if things are going ok or not ). Happy that ur environment is all set, now u can work on the issue :)

ankitm123 avatar Oct 23 '20 12:10 ankitm123

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

jenkins-x-bot avatar Jan 21 '21 14:01 jenkins-x-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle rotten

jenkins-x-bot avatar Feb 20 '21 14:02 jenkins-x-bot

/remove-lifecycle rotten

ankitm123 avatar Oct 05 '21 18:10 ankitm123

Hi @ankitm123 , This issue seems to be a great choice to start my journey towards FOSS contribution The issue is still open, may I work on the same.

anudeep-bpgc avatar Sep 07 '22 17:09 anudeep-bpgc

@anudeep-bpgc yes, please go ahead!

ankitm123 avatar Sep 08 '22 13:09 ankitm123

/assign

anudeep-bpgc avatar Sep 10 '22 15:09 anudeep-bpgc

Hi @ankitm123 , I have raised a PR for this issue, kindly review and update regarding the same

anudeep-bpgc avatar Oct 17 '22 17:10 anudeep-bpgc

Hi @ankitm123 , the issue status still stands open even after the successful merge of #3663 . Can you please check once.

anudeep-bpgc avatar Dec 14 '22 09:12 anudeep-bpgc