jx-docs icon indicating copy to clipboard operation
jx-docs copied to clipboard

Published 20 hours ago • verified publisher icon jenkins-x

Sidebar does not render for devices with screen width less than 768 px

Open ankitm123 opened this issue 4 years ago • 15 comments

Sidebar seems to be missing for devices with width less than 768px. This is for 768 width: image

This is for 767: image

Ideally, I expect an hamburger icon for devices with smaller width.

ankitm123 avatar Jul 14 '20 09:07 ankitm123

@ankitm123 @MarckK hey can I work on this issue during hacktoberfest 2020 ? 😄

salonigoyal2309 avatar Sep 22 '20 14:09 salonigoyal2309

@salonigoyal2309 Awesome, please assign it to urself.

ankitm123 avatar Sep 22 '20 14:09 ankitm123

@ankitm123 I guess I don't have right permissions to assign this issue to myself. Can you assign it to me? 😃

salonigoyal2309 avatar Sep 24 '20 07:09 salonigoyal2309

Try typing /assign it should work.

Edit: This should be part of the contribution guide @MarckK

ankitm123 avatar Sep 24 '20 09:09 ankitm123

/assign

salonigoyal2309 avatar Sep 24 '20 10:09 salonigoyal2309

@salonigoyal2309 Any updates? Just curious, if you are stuck with some issues implementing this :)

ankitm123 avatar Oct 12 '20 16:10 ankitm123

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

jenkins-x-bot avatar Jan 19 '21 11:01 jenkins-x-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle rotten

jenkins-x-bot avatar Feb 18 '21 11:02 jenkins-x-bot

@ankitm123 : What's the status about this?

aminoxix avatar Jun 22 '21 13:06 aminoxix

/remove-lifecycle rotten

ankitm123 avatar Oct 05 '21 18:10 ankitm123

@amino19 the issue still exists.

ankitm123 avatar Oct 05 '21 18:10 ankitm123

@amino19 the issue still exists.

I hadn't fixed the sidebar, the issue was regarding mobile view, and I fixed it here. Pl have a view, & check whether anything from my end has pending to work-on! :slightly_smiling_face:

aminoxix avatar Oct 05 '21 19:10 aminoxix

So, the original issue was missing sidebar for screen width less than 768px, that issue still persists, try to render this page using developer tools for any device with width less than 768px, and the sidebar is still missing: https://jenkins-x.io/v3/about/

Ofc, we dont want a sidebar, instead a hamburger icon is the right thing to do ...

the issue was regarding mobile view, and I fixed it here.

As for mobile view, it still seems broken for anything less than 768px, but that's completely different issue ...

ankitm123 avatar Oct 05 '21 21:10 ankitm123

FYI, If you are fixing it, create an issue and let me know, and I can add an hacktoberfest label to it.

ankitm123 avatar Oct 06 '21 11:10 ankitm123

@ankitm123 Is the issue still persistent? Can I work on this issue ?

shivam-Purohit avatar Sep 17 '22 13:09 shivam-Purohit