jenkins-x-serverless icon indicating copy to clipboard operation
jenkins-x-serverless copied to clipboard

Reduce image size

Open carlossg opened this issue 6 years ago • 6 comments

jenkinsxio/jenkins-filerunner from 1.17GB to 788MB

Do not include the war twice and its exploded version Remove unneeded files from war and jenkinsfile-runner classpath

This should work from a quick test I've run. The only tricky part is what is actually needed from /app/repo

carlossg avatar Jan 15 '19 14:01 carlossg

Hi @carlossg. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jenkins-x-bot avatar Jan 15 '19 14:01 jenkins-x-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: jstrachan

If they are not already assigned, you can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jenkins-x-bot avatar Jan 15 '19 14:01 jenkins-x-bot

/ok-to-test

rawlingsj avatar Jan 15 '19 14:01 rawlingsj

@carlossg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
serverless-jenkins 69621cc9c431f7f0f59728f00c7aad0bed3fe98b link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jenkins-x-bot avatar Jan 15 '19 14:01 jenkins-x-bot

@carlossg we are currently using the docker socket to build this repo on GKE and as such multistage builds are not possible with the version of the docker daemon. We are hoping to switch this to Skaffold/Kaniko very soon

garethjevans avatar Jan 15 '19 16:01 garethjevans

depends on #272

garethjevans avatar Jan 18 '19 15:01 garethjevans