draft-packs
draft-packs copied to clipboard
Liberty pack doesn't work with provided quick start
The liberty
pack doesn't work with the provided Open Liberty quick start. The getting started app used for the quick start uses features that aren't in the default server.xml
provided in the open-liberty/openliberty:javaee7
image. Also, the probePath
specified in the values.yaml
for the chart isn't going to work as the sample application uses MicroProfile health which uses /health
.
I'm going to seek opinions on the Open Liberty mailing list as to the right answer for the first part. Ideally you'd be copying the server.xml
in along with the app but that also means switching from using dropins
to apps
where you'll run in to trouble with the versioned naming of the WAR file. I suspect in the end changes will be needed both here and in the quick start.
For the probe you just need to decide whether you think Spring or MicroProfile is the more likely scenario.
I've submitted two PRs to at least get the Liberty path working with the quick start: https://github.com/jenkins-x-quickstarts/open-liberty/pull/4 https://github.com/jenkins-x/draft-packs/pull/74