jenkins.io
jenkins.io copied to clipboard
jenkins-infra
clarify that once a page has undergone migration, redirection from the old wiki page is necessary.
This is in respect to this issue https://github.com/jenkins-infra/jenkins.io/issues/6887 I have added the content that was asked and added it.
Hi @pyther-hub, it appears that the form validation work has crossed over into this PR. I'm assuming that it should not have been included, similar to the other instance. Unless that should be there, then disregard my comment!
okay sir got it I have removed that part, I do make branch for every issue that I work I do not know how the previous branch changes also appear, I will sure to put my attention to this in future Thank you for your guidance @MarkEWaite and @kmartens27
I do not know how the previous branch changes also appear
When you create the new branch, you need to tell it the base branch that will be used and that needs to be 'master' or 'upstream/master'. If you don't tell it the base branch, then git uses the current branch.
For example, git checkout -b my-new-branch will create a new branch based on the current HEAD (branch). If the current branch is a pull request that you have already submitted, then that will be the new branch. If you instead use git checkout -b my-new-branch upstream/master then it will create the new branch with the same location as 'upstream/master'.
@kmartens27 I have made the changes which you had suggested, sorry I missed few parts earlier on.
@MarkEWaite when you have a moment, would you be able to review the updated content?
Hi @pyther-hub, I was reading over the documentation and the issue this is intended to resolve, and I think this should be a part of the actual instructions instead of a note at the end. It is a crucial step to finish the process properly, so it makes sense to update the instructions to include this. Alternatively, it could be a new section with its own header if the redirect instructions are included.
Understood, @kmartens27 . I'll do the required adjustments. Apologies for the delay, but I'm currently preoccupied with my college unit exams and end-of-semester exams, will do it ASAP
@pyther-hub would you be okay with me making some changes to text to include it in the instructions? I would rather help take care of this and allow you to focus on your exams.
Please take a moment and address the merge conflicts of your pull request. Thanks!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}