jenkins.io
jenkins.io copied to clipboard
jenkins-infra
Footer not fixed to the bottom
Problem with this page
https://www.jenkins.io/author/iam
Expected behavior
The footer should be at the bottom even if the content does not fill the page
I did that here #6218
and it made a mistake with account-app
and it was reverted but without a solution
Actual behavior
it should be in the bottom all the time
Possible solution
I suggest editing it globally, on the Jenkins-components
but this needs an extra edit on both websites, avoiding making it fixed
so I can work on fixing them in Jenkins.io and account-app
but if there's another website let me know it and its repository
I suggest editing it globally, on the Jenkins-components
Sounds like a good idea
We should also give margin-top: 20px; to the footer so the footer won't overlap content this way on other sites. We can do this for precaution.
I'm working on the Jenkins.io-components now, and asking @halkeye first
Just work on it and reference this issue in your PR, @halkeye will review your work once it is ready. This is how open-source is supposed to work. Unless you are afraid someone else might be working on the same issue, otherwise just help yourself.
to fix this issue, my solution is to apply the same thing to both Account app and the main site to avoid conflicts, as I discuses with @halkeye it's not good to change them in the component level
Issues aren't assigned here, and there doesn't seem to be any opened PR related to this issue, go for it!
@Ratul-Saha-003 there were some partial improvements for this, what's missing is flex-grow:1 for the relevant container (.errorcontainer for the error page, .appcontainer for pages like https://www.jenkins.io/changelog/2.440/; probably not a good idea to change style of .container though, since that is used in different contexts)
