jenkins.io icon indicating copy to clipboard operation
jenkins.io copied to clipboard

Published 20 hours ago • verified publisher icon jenkins-infra

Add dark theme

Open vitaly-zdanevich opened this issue 2 years ago • 12 comments

Suggestion

By using https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

vitaly-zdanevich avatar Mar 30 '23 14:03 vitaly-zdanevich

I want to know if this issue the part of someone's Gsoc project or not because last time commented on an issue related to footer enchantment guy opened it as a part of Gsoc project.

PrathamAditya avatar Apr 03 '23 05:04 PrathamAditya

Hi @PrathamAditya I believe there is some misunderstanding. We have not selected the proposals for GSoC yet, so the issue you were referring to while is related to GSoC it was not for anyone’s GSoC project. Just wanted to clarify this. While GSoC is important for open-source, it is not more important than open-source. So in that spirit, feel free to contribute in your own capacity. That would definitely benefit the community a lot.

krisstern avatar Apr 03 '23 10:04 krisstern

Hey i would like to work on this issue. I would like to make sure somebody is not working on this already.

Vandit1604 avatar Apr 14 '23 15:04 Vandit1604

I want to contribute for this issue. Please assign this to me.

lamel0rd avatar Nov 08 '23 07:11 lamel0rd

This is in progress: https://github.com/jenkins-infra/plugin-site/pull/1556 https://github.com/jenkins-infra/jenkins-io-components/pull/110 https://github.com/jenkins-infra/gatsby-plugin-jenkins-layout/pull/24 With these pull requsests it should be possible to have dark mode for the plugin site. The next step would then be moving the style from plugin site repo to this one and enabling it on all the Jenkins sites (main site -- this repo, stories, accounts, updates, ...). After some bad experience with design changes from the main site affecting all the other sites I think this is the safe approach.

@akoolarni maybe when plugin site is ready you can take over this effort? Issues are generally never assigned, so just let people know that you're working on it.

zbynek avatar Nov 08 '23 21:11 zbynek

@zbynek Thankyou! Till when can the plugin site be ready?

lamel0rd avatar Nov 09 '23 11:11 lamel0rd

@akoolarni Your best bet would be to follow the PR https://github.com/jenkins-infra/plugin-site/pull/1556 closely to see when it is merged. Once it is merged it should be ready to go.

krisstern avatar Nov 09 '23 12:11 krisstern

Sure, that would work. Thank you 👍

lamel0rd avatar Nov 09 '23 12:11 lamel0rd

Till then, can I work on some other issue please. It would mean a lot of you help me figuring the same. I will do the best I can.

lamel0rd avatar Nov 09 '23 14:11 lamel0rd

@akoolarni if you're still interested, the PR for the plugin site was merged, so now you can start working on this.

zbynek avatar Jan 06 '24 15:01 zbynek

Yes, I am interested to contribute.

lamel0rd avatar Jan 07 '24 05:01 lamel0rd

Will make a PR soon. Almost solved the issue.

lamel0rd avatar Jan 18 '24 05:01 lamel0rd