#5274 Changes : Part 1

[reveurguy]

#5274 Changes : Part 1

Navbar: changed color to white, changed background Header, Footer: changed background Footer: corrected github icon color to match new background Changed button colors from red to blue to for better contrast and sync

[krisstern]

Thanks for the contribution @reveurguy!

[krisstern]

Looks good to me!

[krisstern]

I think the underlining indicator for highlighting the active menu item is gone again, possibily not a good sign. @reveurguy Is there a way to fix this? See https://github.com/jenkins-infra/jenkins.io/issues/5341.

[reveurguy]

@krisstern The indicator is present, just changed it to blue to match the background color. For the plugins section, it opens on a new site so we would have to change the color and background on that page as well for consistency.

[krisstern]

I see, looks okay to me. Looks like the indicator is not very consistent to me, but that's the same for the current site too. Let's wait for @daniel-beck's review now.

[reveurguy]

Any update on this?

[Vandit1604]

@reveurguy This looks fantastic but the caraousel is not working on the homepage.See here can you please address that as well rebasing might solve it. Also can you correct the position of Stop the war image as there's so much extra space on left of that image Thank You

[MarkEWaite]

Any update on this?

Conflicts need to be resolved. That will also have the benefit of merging the current master branch so that more evaluation can be done.

[krisstern]

And after that I think we will still need a review from @daniel-beck

[reveurguy]

well i have ran into an issue. The make run command is failing for me and i am not able to run the site locally. It was working fine sometime ago, today ran it after sometime and i am getting the error.

the failed to load starts here and after this everything is failed.

Any idea what's causing the issue?

[reveurguy]

I have solved the merge conflicts. I'll make the background changes for navbar, carousel again as it has been removed due to the other changes

[reveurguy]

@reveurguy This looks fantastic but the caraousel is not working on the homepage.See here can you please address that as well rebasing might solve it. Also can you correct the position of Stop the war image as there's so much extra space on left of that image Thank You

ok yeah i'll do that

[krisstern]

@reveurguy Just a word of caution: It is best practice not to name your head branch the same name as the default branch of the repo, in this case master. In the future better use a feature-specific name for your branch to avoid confusion.

[github-actions[bot]]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[kmartens27]

Hi @reveurguy, just wanted to share that Jenkins.io is now using https://github.com/jenkins-infra/jenkins-io-components for the header and footer, so any suggestions would need to go through the corresponding repo. As for the other changes, it appears that the carousel issue is still present, based on @NotMyFault previous comments. Are there any questions or concerns at this time that you might need assistance/clarification on?

[MarkEWaite]

Closing as inactive