jenkins.io icon indicating copy to clipboard operation
jenkins.io copied to clipboard

Published 20 hours ago • verified publisher icon jenkins-infra

Added content to administering-jenkins-on-kubernetes.adoc

Open tanujdevops opened this issue 2 years ago • 4 comments

This PR is to resolve the issue #5457

tanujdevops avatar Oct 04 '22 08:10 tanujdevops

Thanks so much for this @tanujdevops! I had a couple formatting notes that were added separately, and the suggestion for summarizing the list item is optional. Otherwise this looks great, and we truly appreciate your contributions.

Approved, pending @lemeurherve, @smerle33, or @dduportal for confirmation on Kubernetes info

Thanks so much for reviewing and suggesting changes. I have committed all the changes. Waiting for our Kubernetes experts to finally review and merge the commit.

tanujdevops avatar Oct 04 '22 19:10 tanujdevops

Any updates for this PR?

tanujdevops avatar Oct 15 '22 10:10 tanujdevops

As a Jenkins and Kubernetes administrator, I feel like that the current state of this pull request is not enough to be merged.

  • I still do not see why upgrading Kubernetes is referenced?
  • As explained by @StackScribe in #5457 (comment), there should be a link to the installation of Jenkins in Kubernetes (I assume it would be the work you did in #5548?)
  • I would propose to suspend the PR and make the discussion of "what content is expected in the page" to happen in the issue #5457.

Please let me know if I should close this PR and start working when 'What content is expected in the page" is discussed.

tanujdevops avatar Oct 17 '22 13:10 tanujdevops

As a Jenkins and Kubernetes administrator, I feel like that the current state of this pull request is not enough to be merged.

Please let me know if I should close this PR and start working when 'What content is expected in the page" is discussed.

I don't know if you should start a new PR or continue on this one honestly. What do you think about setting it to "draft" to mark it as "work in progress"?

dduportal avatar Oct 17 '22 13:10 dduportal

Hi @tanujdevops, is there anything else that needs to be modified/updated on this PR, or has everything been added? I want to be sure that this can be merged for Hacktoberfest since it is coming to a close in a few days. Thanks!

kmartens27 avatar Oct 28 '22 16:10 kmartens27

Hi @tanujdevops, is there anything else that needs to be modified/updated on this PR, or has everything been added? I want to be sure that this can be merged for Hacktoberfest since it is coming to a close in a few days. Thanks!

Hi @kmartens27 Please close this PR as I have started from scratch in a new PR #6474

tanujdevops avatar Jun 16 '23 06:06 tanujdevops