jenkins.io icon indicating copy to clipboard operation
jenkins.io copied to clipboard

Published 20 hours ago • verified publisher icon jenkins-infra

Update Bootstrap to 5.2, replace Tether with Popper

Open zbynek opened this issue 3 years ago • 3 comments
trafficstars

I tried keeping the styles of the curent website. The roadmap tooltips stopped working at some point, this PR fixes them.

zbynek avatar Sep 11 '22 08:09 zbynek

I'm not against it, and i like upgrading, but I'm curious why.

I'm also wondering how much it'll break plugins and stories site.

halkeye avatar Sep 11 '22 18:09 halkeye

Main motivation is to allow dark/light mode in the future; the way to implement that changes between Bootstrap 4 and 5 so I figured updating Bootstrap first would be nice.

zbynek avatar Sep 11 '22 21:09 zbynek

It's not pixel-perfect, but I think it's ready for review now. CC @janfaracik @uhafner @MarkEWaite @daniel-beck

zbynek avatar Sep 13 '22 20:09 zbynek

@halkeye gentle ping

zbynek avatar Nov 08 '22 21:11 zbynek

@MarkEWaite OK to merge?

zbynek avatar Nov 11 '22 16:11 zbynek

I navigated many different pages on the prototype site and did not detect any issues. I confirmed that the roadmap hover text is available again with this change and that there are many links in the site that jump to https://www.jenkins.io/ when they should instead jump to '/'. I navigated through security advisories and tutorials and pipeline steps reference and roadmap without detecting any issues.

Ready to merge. Thanks!

MarkEWaite avatar Nov 22 '22 00:11 MarkEWaite