Apply navbar, header, footer, and layout improvements

[MarkEWaite]

Create a series of pull requests that apply the changes from #5274 as a series of small, intentional, specific steps towards site improvement.

Each change should be clearly explained for its purpose and its impact should be understood.

[CyberGeni]

@MarkEWaite i want to be assigned to this, but i have questions. what exactly is being changed? is there a design we're using to improve the site, or we're proposing new improvements?

[MarkEWaite]

@CyberGeni the changes in #5274 were useful and helped the site, but they had the unfortunate effect of breaking portions of the site unexpectedly. There were too many changes in a single step and there was not enough validation of the impact of those changes.

The idea in this issue is to have someone review the changes in #5274 and split them into a series of many smaller changes with specific description of the intent and purpose of each change, along with a good review of the site wide impact of the change. Each change would be a pull request that could be evaluated by itself. The submitter can use the various issues reported on #5274 to see the areas of the site that need to be tested with the change.

[CyberGeni]

okay, i think i get that. what would the PR contain?

[MarkEWaite]

It would be a series of pull requests, not a single pull request. The series of pull requests would be incremental improvements to the site based on the improvements made in that larger pull request, with a clear explanation of the purpose of each pull request and the testing that was performed to confirm that the pull request had the desired result and did not have undesirable side effects. Links to relevant pages could be included to show the "before" and "after" or screenshots that show the "before" and "after".

[CyberGeni]

the PR has been merged into master, how do I compare the before and after changes?

[zbynek]

https://github.com/jenkins-infra/jenkins.io/pull/5274/files shows the changes that were merged and later reverted. At least to me it's not clear which parts of the PR are worth re-doing. The consensus is that none of the font family changes should be applied. Then there is

• some CSS formatting -- definitely should not be mixed with design changes. Probably not worth doing (more systematic approach involving modularization could make sense, but that's unrelated).
• the header+footer background -- this got some positive feedback from reviewers of the original PR, maybe worth exploring further (but may still be rejected if more reviewers see problems with it)
• font size changes -- no feedback in original PR
• change of the bullet-point lists in the navigation bar menus -- no feedback in original PR
• other CSS tweaks -- no feedback in original PR

[krisstern]

Hi, I would like to work on this issue for Hacktoberfest if no one else is actively working on it.

[CyberGeni]

hi @krisstern i'm working on this, thanks

[krisstern]

Not a problem! If the status changes please let us know.

[reveurguy]

Hi @MarkEWaite. I can't see any changes being made to this issue. I would like to make the changes again as discussed. I got a bit busy after the breakdown of PRs was discussed and totally forgot about this.

[krisstern]

@CyberGeni Are you still working on the issue?

[reveurguy]

Looks like no-one is working on this. I'll still wait a day for their reply and then start!

[CyberGeni]

hi @krisstern you can work on this. i was swamped and i forgot I had an issue assigned here really sorry for the delay

[krisstern]

@reveurguy You can work on the issue first since Hackoberfest has passed. If you are no longer interested in working on it, then let us know so we can assign it to someone else.

[reveurguy]

Ok i'll work on this

[reveurguy]

Have made the first PR for this: #5845

[Mahmoudgalalz]

Hello @MarkEWaite I would like to work on this, so do I have to made this change to the components repo ?

[krisstern]

Hi @Mahmoudgalalz There is still an "active" PR for this issue: https://github.com/jenkins-infra/jenkins.io/pull/5845

[krisstern]

Not sure about the status of that though

[Mahmoudgalalz]

I notice it and the last comment was in april, and its mentioning it should be in the components repo

[krisstern]

Actually we have been working on the jenkins.io homepage as a part of the retooling effort during GSoC this past summer. Maybe it is better to coordinate with that as the effort is still ongoing. You could work on an PR at the https://github.com/jenkins-infra/jenkins-io-components repo for updating the header and footer. But some parts of the PR proposed maybe in the retooling code to follow.

[Mahmoudgalalz]

I have seen the presentations, about the GSoC, and I think they will not break anything, it just going to enhance the look of the footer and header to match the revamping that happened to the blog section, so yeah all the work will be in the components

I'm doing that as a part of hacktoberfest, so @halkeye @kmartens27 we should have label of hacktoberfest there

[kmartens27]

Hi @Mahmoudgalalz, it appears that the components repo does have the hacktoberfest topic assigned to it, https://github.com/jenkins-infra/jenkins-io-components so you should be all set on that note.

[Mahmoudgalalz]

@kmartens27 Cool, I will be working on it today, I will share the a design of the enhancement before coding it

[krisstern]

Looking forward to seeing your contribution @Mahmoudgalalz!