jenkins.io icon indicating copy to clipboard operation
jenkins.io copied to clipboard

There is no longer an indicator what the active menu item is

Open daniel-beck opened this issue 1 year ago • 3 comments

Previously, pages on jenkins.io had an indicator (underline) what the active menu item is. That is gone now and should be restored.

Screenshots

It's still a little visible in the broken style of plugins.jenkins.io:

Screenshot 2022-08-05 at 14 59 42

Possible Solution

N/A

daniel-beck avatar Aug 05 '22 13:08 daniel-beck

No, the pages didn't had any indicator previously. There was a slight opacity change on hover , that i don't know how has been deactivated, i'll add that again. Only the plugin site had that underline previously as well.

https://deploy-preview-1187--jenkins-plugin-site-pr.netlify.app/ https://deploy-preview-5315--jenkins-io-site-pr.netlify.app/

It can be viewed in the above deploy previews.

reveurguy avatar Aug 06 '22 08:08 reveurguy

No, the pages didn't had any indicator previously.

Well, they should have :) This was more noticeable because in the past, we had a lot more top-level menu items that didn't just open menus. Today it's just "Blog" and "Plugins" and it's true that "Blog" doesn't have an active link format. I did some digging and this was broken for the "Blog" entry in https://github.com/jenkins-infra/jenkins.io/commit/19b69a822e0d3cfe13e729ca2ba8e1dfe8da3765.

So, not caused by your PR, but a bug nonetheless.

daniel-beck avatar Aug 08 '22 10:08 daniel-beck

Per https://github.com/jenkins-infra/jenkins.io/pull/5347#issuecomment-1209616278

daniel-beck avatar Aug 09 '22 16:08 daniel-beck

Hi, I would like to work on a PR for this issue

krisstern avatar Oct 28 '22 01:10 krisstern

Is this still an issue? I just checked it seems that for Plugins the indicator is back now.

krisstern avatar Oct 28 '22 01:10 krisstern

https://github.com/jenkins-infra/jenkins.io/pull/5355 took care of it. Thanks for the reminder.

daniel-beck avatar Oct 28 '22 09:10 daniel-beck

@daniel-beck You are welcome!

krisstern avatar Oct 28 '22 12:10 krisstern