vuepress-deploy icon indicating copy to clipboard operation
vuepress-deploy copied to clipboard

Update Node from v16.18 to v18.19

Open undefined-ux opened this issue 2 years ago • 4 comments

Description

Update Node.js version to 18.19

undefined-ux avatar Jan 18 '24 01:01 undefined-ux

Is this repository still under active development, @jenkey2011? We are using the vuepress-deploy action in several project and are faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions (e.g. required: { node: '>=18.0.0' }, see this deployment workflow). The v16.19.1 Docker Image has several strong vulnerabilities. It would be helpful to merge this PR.

mahula avatar Apr 06 '24 12:04 mahula

Hello @undefined-ux, as said above we were also faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions. Since this repo des not seem to be maintained anymore, we forked it and updated the Github Action's docker file node version to 20.12.1, which meets our requirements. We will continue to maintain int to keep this action current and useful You can find it here. Please give it a try and give feedback, how it works for your projects. Kind regards, @mahula from @IT4Change

mahula avatar May 01 '24 18:05 mahula

Hello @undefined-ux, as said above we were also faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions. Since this repo des not seem to be maintained anymore, we forked it and updated the Github Action's docker file node version to 20.12.1, which meets our requirements. We will continue to maintain int to keep this action current and useful You can find it here. Please give it a try and give feedback, how it works for your projects. Kind regards, @mahula from @IT4Change

It works perfectly. Thank you for your continued work maintaining this project.

undefined-ux avatar May 06 '24 06:05 undefined-ux

It's can be merge?

Wulian233 avatar Jul 01 '24 02:07 Wulian233