rednotebook
rednotebook copied to clipboard
jendrikseipp
Adds a dockerfile
Summary of the changes in this pull request
non-linux releases of rednotebook are a bit of a pain. So for all those of you out there who know how to both xwindows and docker, why not just run it on a linux container?
I dont know how useful this is for others, it is certainly useful for me for when I switch mac laptops and dont want to have to do a giant dance involving brew, gtk installations and lots of time.
As a side note, I believe the icon theme listed on line 20 is missing from your ubuntu apt definition. I got a bunch of warnings before I installed that.
Pull request checklist
- [x] I have added an entry in
CHANGELOG.mdincluding my name and issue and/or pull request number. - [ ] If applicable: I have removed the corresponding entry in
TODO.md.
yup, I'll try to get to it this weekend. I should be able to test this out in both environments.
Also, how do we add "adwaita-icon-theme-full" to the ubuntu configuration denoted in "ppa:rednotebook/stable", so I don't need to enumerate it out in the dockerfile.
@kathenas What do you think about adding adwaita-icon-theme or adwaita-icon-theme-full to debian/control? I'm unsure whether one of these core GTK package should be a hard dependency.
@kathenas What do you think about adding adwaita-icon-theme or adwaita-icon-theme-full to debian/control? I'm unsure whether one of these core GTK package should be a hard dependency.
On Debian/Ubuntu when libgtk-3-0 is pulled in, the packages adwaita-icon-theme and hicolor-icon-theme are also with other packages additionally depending on the Desktop Environment. Adding a hard dependency is not warranted.
@echaz Do you still want to pursue this (see my earlier message https://github.com/jendrikseipp/rednotebook/pull/614#pullrequestreview-894946485 for the next steps)?