JEM-Project icon indicating copy to clipboard operation
JEM-Project copied to clipboard

language packs 4.2.2 have inside of the files 4.0.0

Open jojo12 opened this issue 1 year ago • 7 comments

this should be changed, because it irritates! At least for the new packages for 4.2.3!

jojo12 avatar Jul 22 '24 07:07 jojo12

In the master branch all english language files have version 4.2.2. IN the German language pack there are 4.0.0 and others. So it is wrong on transifex. How can we change that?

Heklaterriol avatar Jul 24 '24 19:07 Heklaterriol

I think that the version number (mayor:minor:patch) shouldn't be include in the files. If JEM files have to indicate a version, it will be mayor version, for example JEM v4. Each version is tagged in git and jem.xml (and orhers xml files of JEM package and extenxion). So, we don't have to changed all files. It is an idea.

mckillo avatar Jul 24 '24 19:07 mckillo

Others extensions (JCE, Yootheme, Akkeba, ..) don't write the version number in all files, they have a simple header:

<?php
/**
 * @package     JCE
 * @subpackage  Editor
 *
 * @copyright   Copyright (C) 2005 - 2020 Open Source Matters, Inc. All rights reserved.
 * @copyright   Copyright (c) 2009-2024 Ryan Demmer. All rights reserved
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */
<?php
/**
* @package   akeebabackup
* @copyright Copyright (c)2006-2023 Nicholas K. Dionysopoulos / Akeeba Ltd
* @license   GNU General Public License version 3, or later
*/
<?php
/**
* @package   Widgetkit
* @author    YOOtheme http://www.yootheme.com
* @copyright Copyright (C) YOOtheme GmbH
* @license   http://www.gnu.org/licenses/gpl.html GNU/GPL
*/

<?php

/**
 * Kunena Component
 *
 * @package         Kunena.Administrator.Template
 * @subpackage      Categories
 *
 * @copyright       Copyright (C) 2008 - 2023 Kunena Team. All rights reserved.
 * @license         https://www.gnu.org/copyleft/gpl.html GNU/GPL
 * @link            https://www.kunena.org
 **/

and Joomla too:

<?php

/**
 * @package     Joomla.Site
 * @subpackage  com_content
 *
 * @copyright   (C) 2006 Open Source Matters, Inc. <https://www.joomla.org>
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

mckillo avatar Jul 25 '24 08:07 mckillo

I agree: it is better to have no version inside the language files!

jojo12 avatar Jul 25 '24 08:07 jojo12

In all files, PHP too (except the XML file with version field).

mckillo avatar Jul 25 '24 09:07 mckillo

Ok. So it would also be good to have a uniform header.

Heklaterriol avatar Jul 25 '24 10:07 Heklaterriol

We can remove all the version number in the files for version 4.2.3. I create a branch for that

Heklaterriol avatar Aug 04 '24 19:08 Heklaterriol

I presume we will keep the version number in the installation file?

ernst67 avatar Aug 24 '24 07:08 ernst67

Yes, in the xml files of the extension and each plugin/module

Heklaterriol avatar Aug 24 '24 07:08 Heklaterriol