Jane Morrison
Jane Morrison
I removed the rotation in the assign_wcs step and now I do not get the tilts in wavelength. @drlaw1558 I will see what you get after your testing.
@tapastro This PR has how I was planning on moving the pixel replacement. I have not tested it yet. I just wanted to check it this method seems like the...
@tapastro The pixel replace step assumed the input data was a single input not a model container since it was written for calspec2. Now the pixel_replacement step needs to also...
@emolter @hbushouse I have to code working as intended. I just can not get the pixel_replace output filenames to be correct. This PR moves where pixel_replace is called. When it...
@hbushouse Regression tests: Several updates to regression test will cause failures. I added pixel_replace.skip=False for MIRI LRS SLIT and SLITLESS since that is default now. All those down stream results...
I made the suggested changes now running regression testing: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1432/
@hbushouse I have about twice as many regression test failures as I had with an earlier running. I think the new failures are related to a different pr and once...
@hbushouse @nden I did a git fetch and rebase. Why does it say "This branch is out-of-date- with the base branch" It should not be with a fetch and rebase....
@howard - the regression test look as expected. There are 74 failures. The majority of these are because now S_PIXREPL is written to the header of files as SKIPPED. It...
I think that failure was related to a different PR change that did not have the truth files. I just ran pytest test_miri_lrs_slitless.py -s --bigdata --basetemp='/Users/morrison/scratch' -k test_miri_lrs_slitless_tso3 and I...