xandikos icon indicating copy to clipboard operation
xandikos copied to clipboard

Dockerfile ENTRYFILE needs to be array

Open chmac opened this issue 3 years ago • 3 comments

Following #144 I've been trying understand the docker docs on entrypoint vs cmd. Okay, think I got it.

I think the issue is that according to this and the docker docs the CMD value is ignored if ENTRYPOINT is a string. It needs to be an array I think.

If CMD is used to provide default arguments for the ENTRYPOINT instruction, both the CMD and ENTRYPOINT instructions should be specified with the JSON array format.

I think that means the CMD value in the xandikos dockerkfile is ignored.

I think the ENTRYPOINT could be as follows:

ENTRYPOINT ["python3", "-m", ":xandikos.web", "--port=8000", "--listen-address=0.0.0.0", "-d/data"]

But you probably want to double check that!

I think this explains why I didn't get the default directories created in docker.

chmac avatar Jan 26 '22 07:01 chmac

Are you still working on this?

jelmer avatar Mar 05 '22 13:03 jelmer

An, I wasn't intending to work on it, I was just suggesting the change. I have only pulled your docker image but not built it locally so I figured it should be a quick test for you if you already have all the docker stuff setup.

chmac avatar Mar 05 '22 14:03 chmac

Done

walkertraylor avatar May 11 '22 03:05 walkertraylor