prometheus-xmpp-alerts
prometheus-xmpp-alerts copied to clipboard
jelmer
Add muc/omemo support
From @ichthyx in #40:
This PR add support for MUC (groupchat) and OMEMO (bot to user) and MUC OMEMO.
Currently private discussion (from user to bot) doesn't support omemo, we should implement omemo support in message() function. Not sure if I have the time for do it now, maybe later.
It add a new dependency which is slixmpp-omemo. Most of the code come from the slixmpp example : https://codeberg.org/poezio/slixmpp-omemo/src/branch/main/examples/echo_client.py
I used black to format code, it seems to have mess a lot of code, if you can suggest your way of formatting.
Is there any chance you could submit the changes to introduce MUCs and the omemo support separately?
it seems this function ignores mto completely if self.muc is set, which is confusing; cam we just pass in self.muc_jid ?
Yeah I should review this, probably got a bit too fast using the slixmpp example.
Is there any chance you could submit the changes to introduce MUCs and the omemo support separately?
What do you mean exactly ? One PR for MUCs support, and one PR for OMEMO ?
Is there any chance you could submit the changes to introduce MUCs and the omemo support separately?
What do you mean exactly ? One PR for MUCs support, and one PR for OMEMO ?
Yeah - I'm not sure how easy or hard this would be so feel free to push back, but it would make reviewing the changes easier at least.
Note: this PR has conflicted, https://github.com/ichthyx/prometheus-xmpp-alerts/tree/omemo is probably a better start.