Jelmer Vernooij
Jelmer Vernooij
I think that's an argument for improving the default log format rather than making the log format configurable. The change isn't minimal, because we now have more code paths -...
The fact that not everything is tested (although @ix5 has made massive strides improving overall test coverage) isn't a good reason for not adding tests for new features (and reducing...
An alternative to a plugin system might be to have say a good Python package that uses the API to automatically moderate? That might be simpler to set up and...
> https://www.mardy.it/blog/2022/12/leaving-canonical-again.html FWIW I haven't been able to reproduce this, it just loads 6 comments for me from different devices.
By default, open() uses your environment to detect the encoding; utf-8 may be common nowadays, but it seems unnecessary to force everybody to use it. See https://docs.python.org/3/library/functions.html#open and https://docs.python.org/3/library/locale.html#locale.getencoding What...
Marking this as draft, since either way the PR needs rebasing.
Closing this, since it's been open for >1.5y. It's also not clear that it is necessary to me, and it's unreadable in its current shape.
ping @sprang
PTAL - I believe these should all be fixed now.
Ping @joanvila