jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

use LinkButton instead of dangerouslySetInnerHTML

Open terite opened this issue 1 year ago • 5 comments

Let's use the component that already exists for similar reasons to here: https://github.com/jellyfin/jellyfin-web/pull/5213

terite avatar Feb 24 '24 20:02 terite

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 24 '24 20:02 sonarqubecloud[bot]

Cloudflare Pages deployment

Latest commit f759202
Status ✅ Deployed!
Preview URL https://a0b21c60.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs View bot logs

jellyfin-bot avatar Feb 24 '24 20:02 jellyfin-bot

👍 I like the direction of both PRs. Using the "dangerous" prop was never intended to be a long term solution. We should probably also migrate to using the react-router <Link> component.

thornbill avatar Feb 24 '24 22:02 thornbill

We should probably also migrate to using the react-router <Link> component.

react-router-dom's` link implementation is a bit more complex than one might expect. I'd rather not swap it in without additional testing. I'd also like to keep this PR more focused.

terite avatar Feb 25 '24 02:02 terite

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Mar 05 '24 07:03 jellyfin-bot