jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

make a React/TypeScript version of emby-checkbox

Open terite opened this issue 1 year ago • 4 comments

CheckBoxElement was a wrapper around emby-checkbox which worked by having React create the custom component via dangerouslySetInnerHTML. This has a fair amount of quirks, quickly becomes less than typesafe, results in components that are difficult to attach event listeners to, and among other things.

Instead of wrapping the custom emby components, let's create idiomatic react versions of them.

  • They react better to updates.
  • No more having to escape html.
  • Want data attributes? Just set them directly.
  • Supports both controlled and uncontrolled components.

terite avatar Feb 19 '24 07:02 terite

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Feb 29 '24 03:02 sonarqubecloud[bot]

Cloudflare Pages deployment

Latest commit fa0bee1
Status ✅ Deployed!
Preview URL https://dc2332d8.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs View bot logs

jellyfin-bot avatar Feb 29 '24 03:02 jellyfin-bot

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Jun 09 '24 07:06 jellyfin-bot