jellyfin-web Move RemoteControlSection and subcomponents from remotecontrol to separate components

Move RemoteControlSection and subcomponents from remotecontrol to separate components

Open dkacperski97 opened this issue 1 year ago • 3 comments

Changes Move RemoteControlSection, SendMessageSection, SendTextSection, NavigationSection and PlaybackCommandButton from remotecontrol to separate components and migrate these components to Typescript to make them easier to convert to React in the future. Continuation of the work on refactoring the remotecontrol component started in https://github.com/jellyfin/jellyfin-web/pull/5108

I have some thoughts about the code that I moved from remotecontrol. updateSupportedCommands is only called when the player changes, but it depends on supportedCommands. Shouldn't this function be also called in updatePlayerState? Or maybe supportedCommands can't change unless the player changes. But is it then necessary to change the value of currentPlayerSupportedCommands in updatePlayerState? To get to the bottom of this I would have to study the code of playbackManager, but that would take a lot of time, so right now I left this logic as it was. This would also answer the questions I had about showMuteButton and showVolumeSlider in https://github.com/jellyfin/jellyfin-web/pull/5108

Jan 15 '24 01:01 dkacperski97

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
13.2% Duplication on New Code

See analysis details on SonarCloud

Jan 19 '24 07:01 sonarqubecloud[bot]

~Please rebase this on the latest from master. Thanks!~

I overlooked that this is dependent on #5108. Please apply the comments here to that PR. I’m going to label this one as blocked until it is merged. Thanks!